Use apply-refact 0.12.0 #3469
Merged
Use apply-refact 0.12.0 #3469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
commented
Jan 27, 2023
| @@ -609,7 +601,7 @@ applyHint recorder ide nfp mhint = | |||
| (anns', modu') <- | |||
| ExceptT $ mapM (uncurry Refact.applyFixities) | |||
| $ postParseTransform (Right (anns, [], dflags, modu)) rigidLayout | |||
| liftIO $ (Right <$> withRuntimeLibdir (Refact.applyRefactorings' position commands anns' modu')) | |||
| liftIO $ (Right <$> Refact.applyRefactorings' position commands anns' modu') | |||
There was a problem hiding this comment.
This is curious, this code-path is definitely not exercised for GHC >= 9.2, since the API in apply-refact has changed in 0.11.0. Additionally, I don't think we need the hack withRuntimeLibdir here because the libdir is only needed for parsing and we pass in a module already.
|
PR breaks because of tweag/ormolu#981 |
hasufell
approved these changes
Jan 27, 2023
michaelpj
approved these changes
Jan 27, 2023
pepeiborra
reviewed
Jan 28, 2023
fendor
force-pushed
the
fix/3241
branch
6 times, most recently
from
78b66ce to
d3508f3
Compare
georgefst
approved these changes
Feb 2, 2023
wz1000
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Use apply-refact 0.12.0 * Limit ormolu version to < 0.5.3 (cherry picked from commit 065957e)
wz1000
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Use apply-refact 0.12.0 * Limit ormolu version to < 0.5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3241 by upgrading to apply-refact 0.12.0 for compatible GHC versions. Other GHC versions are not affected.